Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort more than 100 pages chronologically #10476

Merged
merged 5 commits into from Sep 3, 2019

Conversation

@planarvoid
Copy link
Contributor

commented Sep 3, 2019

Fixes #10440

This PR copies the Calypso behaviour where it sorts more than 100 published pages chronologically instead of topologically. In this view we're not showing parent/child relationship between the pages. I've also added unit tests to cover this use case.

To easier test this you can the MAX_TOPOLOGICAL_PAGE_COUNT to a more reasonable number like 10.

To test:

  • Go to a site with < 100 published pages
  • Check that they are still ordered topologically
  • Go to a site with >= 100 published pages
  • Check that they are ordered chronologically in a descending order by the published date.
  • Check that you can't see the parent/child relationship

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@planarvoid planarvoid added this to the 13.3 milestone Sep 3, 2019
@planarvoid planarvoid requested a review from khaykov Sep 3, 2019
@planarvoid planarvoid self-assigned this Sep 3, 2019
@peril-wordpress-mobile

This comment has been minimized.

Copy link

commented Sep 3, 2019

You can test the changes on this Pull Request by downloading the APK here.

@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Sep 3, 2019
@khaykov khaykov self-assigned this Sep 3, 2019
@khaykov
khaykov approved these changes Sep 3, 2019
Copy link
Member

left a comment

Looks good 👍

@khaykov khaykov merged commit a2f283f into develop Sep 3, 2019
5 checks passed
5 checks passed
Peril All green. Yay.
Details
ci/circleci: Installable Build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@khaykov khaykov deleted the feature/stop_sorting_100_plus_pages branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.