Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for local auto save that doesn't work in Gutenberg #10483

Conversation

@daniloercoli
Copy link
Contributor

commented Sep 4, 2019

Fixes #10415 by signaling to the host app that changes has been made in GB.
The app then, once received the event, follow the normal flow already implemented for Aztec: asks the content and title to the editor and check for changes.

To test: Follow the steps in the original issue.

GB-Mobile PR: wordpress-mobile/gutenberg-mobile#1351

Update release notes:

  • [ x ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@peril-wordpress-mobile

This comment has been minimized.

Copy link

commented Sep 4, 2019

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

left a comment

I tested this on Pixel 3a, and it fixes the issue as described 🎉 !

One note:

I did not observe the line described in the original issue being invoked. Still, the changes were saved locally, when I followed the steps there, after applying the fix in this PR.

I placed a breakpoint on that line, and it was touched, when the post is opened, but that also occurs before the fix. 🤷‍♂ Is that expected?

Copy link
Contributor

left a comment

Nice work!
Working as expected!

@etoledom etoledom referenced this pull request Sep 6, 2019
1 of 1 task complete
daniloercoli added 2 commits Sep 6, 2019
…ss-Android into fix/10415-Local-auto-save-doesnt-work-in-Gutenberg

* 'develop' of https://github.com/wordpress-mobile/WordPress-Android: (81 commits)
  Update gutenberg-mobile ref to v1.12.0 release
  Update FluxC to the tagged version
  Update FluxC version to 1.4.0-beta-1
  Update release notes from gutenberg-mobile 1.12.0 release
  Update metadata translations for 13.2
  Bump version number
  Updates translations
  revert IDE change to Project.xml
  revert IDE change to Project.xml
  Hide Sharing manage options for non-admins
  Removed unused attribute.
  Add Other post type to posts and pages
  Show an empty screen when all insights are removed
  Fix release notes
  Logic fixes based on the PR feedback
  Address PR comments
  fix small lint errors
  Removed exit transition and ActivityCompat call.
  Removed slide from left animation.
  use viewinteraction for choosing options menu
  ...

# Conflicts:
#	libs/gutenberg-mobile
@daniloercoli daniloercoli changed the base branch from develop to gb/release-1.13.0 Sep 19, 2019
@daniloercoli daniloercoli merged commit c85ac03 into gb/release-1.13.0 Sep 19, 2019
6 checks passed
6 checks passed
Peril All green. Nice work.
Details
ci/circleci: Installable Build Your tests passed on CircleCI!
Details
ci/circleci: connected-tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: strings-check Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@daniloercoli daniloercoli deleted the fix/10415-Local-auto-save-doesnt-work-in-Gutenberg branch Sep 19, 2019
@mchowning mchowning referenced this pull request Sep 20, 2019
2 of 2 tasks complete
mchowning added a commit that referenced this pull request Sep 23, 2019
@mchowning mchowning referenced this pull request Sep 23, 2019
1 of 1 task complete
mchowning added a commit that referenced this pull request Sep 23, 2019
…ase_note

Add release notes for local autosave from #10483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.