Fixes #8002: Add ability to change username #10497
Fixes #8002: Add ability to change username
Note: this is the merge of the feature branch. Code and feature in this branch was already reviewed and tested in:
There was one remaining issue and it was fixed in FluxC via wordpress-mobile/WordPress-FluxC-Android#1378 - This PR targets a recent FluxC beta (1.4.0-beta-1) including that fix.
Update release notes:
This flag will determine if dialog will be dismissed after confirm is clicked. It's default behavior is to dismiss after confirm since the existing implementations utilize this.
…ality can be shared. The class now has the common functionality that will be needed in the sign-up and the account settings flow. The behaviour that differs with the header & analytics will be implemented in the respective classes that extend it.
…d Injector method since it makes it easier to test. The FragmentInjector can be replaced during tests. The older method requires modification to the TestComponents/TestModules etc. Also corrected how injections were taking place by moving injection to the subtype instead of the base type since the best practice is to inject subtypes.
Verifies that the suggestions functionality is still intact even though the implementation has been modified. Created an environment where the fragment could be tested in isolation utilizing Mockito,Dagger's Android Injection and a fragment container.
…een. - Create the new fragment with the functionality specific to the Settings behaviour. - The Account Settings username component now ties into the feature and gets updated once the username has been changed. - Updated FluxC hash to utilize the changes related to this PR from the username changer feature branch. - Added the fragment to the ApplicationModule and made a minor typo fix.