Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue/10680 extract upload media phase 2 #10763
This is a "final" PR of
Some test can be found on pb3aDo-ag-p2
PR submission checklist:
This commit attempts to copy over the some (most?) of media related methods of EditPostActivity to a new class EditorMedia. If the dependencies are resolved, this will provide a basis for extracting media logic from EditPostActivity.
This is an attempt to create the communicatino between the EditPostActivity and EditorMedia. Some, if not all, of the functions in EditorMediaListener are temporary, because they are not the ideal way to communicate the information. We'll need to move a lot of logic between EditPostActivity and EditorMedia to have more meaningful functions in the listener.
…/refactor-add-media-to-editor-functionality # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java # WordPress/src/main/java/org/wordpress/android/ui/posts/editor/EditorMedia.kt
I've found a crash: