Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Spacer block in production #10817

Closed
wants to merge 5 commits into from
Closed

Conversation

@geriux
Copy link
Member

geriux commented Nov 19, 2019

Updates Gutenberg so the Spacer block is available in production.

Gutenberg-> WordPress/gutenberg#18605

To test:

  • Run the app without metro running
  • Start a new post
  • Select the Spacer block
    • Change the height of the Spacer
    • Move the block between other ones and check it works correctly
    • Remove the block
    • Add one again
  • Save as draft
  • Open your draft and check the Spacer block is shown correctly

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Nov 19, 2019

You can test the changes on this Pull Request by downloading the APK here.

@geriux geriux marked this pull request as ready for review Nov 19, 2019
@geriux geriux requested a review from pinarol Nov 19, 2019
@geriux geriux added this to the 13.8 milestone Nov 19, 2019
@geriux geriux requested review from marecar3 and removed request for pinarol Nov 20, 2019
@marecar3

This comment has been minimized.

Copy link
Contributor

marecar3 commented Nov 26, 2019

Hey @geriux, when we bring some changes to WPAndroid app from the gutenberg mobile repo, it's always a good practice to start a branch name with a prefix gutenberg/ or gb/.

@geriux

This comment has been minimized.

Copy link
Member Author

geriux commented Nov 26, 2019

Hey @geriux, when we bring some changes to WPAndroid app from the gutenberg mobile repo, it's always a good practice to start a branch name with a prefix gutenberg/ or gb/.

Thanks for the suggestion 🙌 I'll keep this in mind for future PRs since this one won't be merged and it's just to test all is working ok

@geriux geriux closed this Nov 26, 2019
@geriux geriux deleted the update-gutenberg-spacer-block branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.