Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed NPE in LoginUsernamePasswordFragment #10833
After the user leaves
To make the testing easier, change the throttle delay on-site refresh (here) to something reasonable, like 10 seconds.
PR submission checklist:
malinajirka left a comment
Great investigation @khaykov !! I've tried to carefully review and test the code and AFAICT it works like a charm. However, tbh it's quite complicated and since it's a vital part of the app, I'd feel more comfortable if one more developer reviewed it.
I'd also suggest keeping an eye on "failed login" tracks to make sure we didn't break anything.