Skip to content

Conversation

@oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Nov 27, 2025

Description

Pass empty interceptors list to API client constructors following the addition of interceptors support in wordpress-rs.

Automattic/wordpress-rs#1041

Changes:

  • Update WpApiClient, WpLoginClient, and WpRequestExecutor calls to include interceptors = emptyList()
  • Bump wordpress-rs version in libs.versions.toml

Testing instructions

This is a dependency update that adds interceptors support to wordpress-rs API clients. Since we're passing empty interceptor lists, everything should work exactly as before - no functional changes expected.

For the extra diligent, you can verify the affected code paths:

WpComApiClient (Subscribers)

  1. Go to My Site → More → Subscribers
  2. Verify the subscribers list loads correctly

WpLoginClient (Self-hosted site login)

  1. Go to Me → Experimental Features
  2. Enable Application Password log in
  3. Tap the site switcher dropdown (▼) in the top right of My Site
  4. Select Add self-hosted site
  5. Complete the login flow for a self-hosted WordPress site
  6. Verify site is added successfully

Part of CMM-998

Pass empty interceptors list to API client constructors following the
addition of interceptors support in wordpress-rs.

Automattic/wordpress-rs#1041

Changes:
- Update `WpApiClient`, `WpLoginClient`, and `WpRequestExecutor` calls
  to include `interceptors = emptyList()`
- Bump wordpress-rs version in libs.versions.toml
@oguzkocer oguzkocer added this to the 26.5 milestone Nov 27, 2025
@sonarqubecloud
Copy link

@wpmobilebot
Copy link
Contributor

Project dependencies changes

list
! Upgraded Dependencies
rs.wordpress.api:android:trunk-e062d94e66354cad9bd710219f321104782bb6fc, (changed from trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c)
rs.wordpress.api:kotlin:trunk-e062d94e66354cad9bd710219f321104782bb6fc, (changed from trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c)
tree
 +--- project :libs:fluxc
-|    \--- rs.wordpress.api:android:trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c
-|         +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
-|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
-|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.16.3 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
-|         +--- net.java.dev.jna:jna:5.18.1
-|         +--- rs.wordpress.api:kotlin:trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
-|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+|    \--- rs.wordpress.api:android:trunk-e062d94e66354cad9bd710219f321104782bb6fc
+|         +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
+|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
+|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.16.3 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
+|         +--- net.java.dev.jna:jna:5.18.1
+|         +--- rs.wordpress.api:kotlin:trunk-e062d94e66354cad9bd710219f321104782bb6fc
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.1 (*)
+|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
-\--- rs.wordpress.api:android:trunk-3d2dafdc1f8b058b4ed9101673fdf690671da73c (*)
+\--- rs.wordpress.api:android:trunk-e062d94e66354cad9bd710219f321104782bb6fc (*)

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22372-7000b29
Commit7000b29
Direct Downloadwordpress-prototype-build-pr22372-7000b29.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22372-7000b29
Commit7000b29
Direct Downloadjetpack-prototype-build-pr22372-7000b29.apk
Note: Google Login is not supported on these builds.

@oguzkocer oguzkocer marked this pull request as ready for review November 27, 2025 15:25
@oguzkocer oguzkocer requested a review from a team as a code owner November 27, 2025 15:25
@oguzkocer oguzkocer requested review from adalpari and removed request for a team November 27, 2025 15:25
@oguzkocer oguzkocer enabled auto-merge (squash) November 27, 2025 15:25
@oguzkocer oguzkocer requested a review from jkmassel November 27, 2025 15:25
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.03%. Comparing base (dc52538) to head (7000b29).
⚠️ Report is 7 commits behind head on trunk.

Files with missing lines Patch % Lines
...wordpress/android/ui/dataview/DataViewViewModel.kt 50.00% 1 Missing ⚠️
...i/jetpackrestconnection/JetpackConnectionHelper.kt 0.00% 1 Missing ⚠️
.../android/ui/subscribers/AddSubscribersViewModel.kt 0.00% 1 Missing ⚠️
...fluxc/network/rest/wpapi/rs/WpApiClientProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #22372      +/-   ##
==========================================
- Coverage   39.03%   39.03%   -0.01%     
==========================================
  Files        2203     2203              
  Lines      106316   106318       +2     
  Branches    15057    15057              
==========================================
  Hits        41499    41499              
- Misses      61328    61330       +2     
  Partials     3489     3489              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oguzkocer oguzkocer merged commit 06a7f4e into trunk Nov 27, 2025
27 checks passed
@oguzkocer oguzkocer deleted the update-wordpress-rs-to-trunk-e062d94e66354cad9bd710219f321104782bb6fc branch November 27, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants