From dd1885f3dee796c1a3c53502ffbad8c112196ee9 Mon Sep 17 00:00:00 2001 From: Maxime Biais Date: Mon, 13 Apr 2015 13:38:37 +0200 Subject: [PATCH] fix #2521: check decoded bitmap is not null before putting it in the LRU cache --- .../java/org/wordpress/android/ui/media/MediaUtils.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/media/MediaUtils.java b/WordPress/src/main/java/org/wordpress/android/ui/media/MediaUtils.java index f849e859efc2..bd09b76fb3ae 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/media/MediaUtils.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/media/MediaUtils.java @@ -21,7 +21,6 @@ import org.wordpress.android.R; import org.wordpress.android.WordPress; import org.wordpress.android.WordPressDB; -import org.wordpress.android.models.Blog; import org.wordpress.android.models.MediaFile; import org.wordpress.android.util.AppLog; import org.wordpress.android.util.AppLog.T; @@ -131,7 +130,9 @@ protected Bitmap doInBackground(Uri... params) { if (bitmap == null) { URL url = new URL(uri); bitmap = BitmapFactory.decodeStream(url.openConnection().getInputStream()); - WordPress.getBitmapCache().put(uri, bitmap); + if (bitmap != null) { + WordPress.getBitmapCache().put(uri, bitmap); + } } return bitmap; @@ -145,7 +146,7 @@ protected Bitmap doInBackground(Uri... params) { protected void onPostExecute(Bitmap result) { ImageView imageView = mReference.get(); - if (imageView != null) { + if (imageView != null && result != null) { if (imageView.getTag() == this) { imageView.setImageBitmap(result); fadeInImage(imageView, result);