issue/3100-fab-animation #3110

Merged
merged 1 commit into from Aug 27, 2015

Projects

None yet

3 participants

@nbradbury
Contributor

Fixes #3100 - the problem turned out not to be in our code but instead due to this bug in FloatingActionButton which causes it to briefly appear even when made invisible. This bug doesn't occur on devices running Lollipop, but I reproduced it on 4.1 and 4.4.4.

Note that this has not been fixed in the latest version of the design support library (23), and the suggested solution in that Google issue (use the built-in show() and hide() methods) doesn't work.

So, on pre-L devices we simply don't hide the FAB or animate it in.

@nbradbury nbradbury Only hide & animate FAB on Lollipop or higher
158c0c5
@nbradbury nbradbury added this to the 4.5 milestone Aug 27, 2015
@tonyr59h tonyr59h self-assigned this Aug 27, 2015
@tonyr59h tonyr59h added the bug label Aug 27, 2015
@tonyr59h
Contributor

Couldn't get it to reproduce on my S3 with 4.1.2, but the emulator certainly showed it. Gotta love the support library 😈

:shipit:

@tonyr59h tonyr59h merged commit 0a06ece into develop Aug 27, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tonyr59h tonyr59h deleted the issue/3100-fab-animation branch Aug 27, 2015
@maxme
Contributor
maxme commented Aug 28, 2015

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment