Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/3100-fab-animation #3110

Merged
merged 1 commit into from Aug 27, 2015
Merged

issue/3100-fab-animation #3110

merged 1 commit into from Aug 27, 2015

Conversation

@nbradbury
Copy link
Contributor

nbradbury commented Aug 27, 2015

Fixes #3100 - the problem turned out not to be in our code but instead due to this bug in FloatingActionButton which causes it to briefly appear even when made invisible. This bug doesn't occur on devices running Lollipop, but I reproduced it on 4.1 and 4.4.4.

Note that this has not been fixed in the latest version of the design support library (23), and the suggested solution in that Google issue (use the built-in show() and hide() methods) doesn't work.

So, on pre-L devices we simply don't hide the FAB or animate it in.

@nbradbury nbradbury added this to the 4.5 milestone Aug 27, 2015
@tonyr59h tonyr59h self-assigned this Aug 27, 2015
@tonyr59h tonyr59h added the [Type] Bug label Aug 27, 2015
@tonyr59h
Copy link
Contributor

tonyr59h commented Aug 27, 2015

Couldn't get it to reproduce on my S3 with 4.1.2, but the emulator certainly showed it. Gotta love the support library 😈

:shipit:

tonyr59h added a commit that referenced this pull request Aug 27, 2015
issue/3100-fab-animation
@tonyr59h tonyr59h merged commit 0a06ece into develop Aug 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tonyr59h tonyr59h deleted the issue/3100-fab-animation branch Aug 27, 2015
@maxme
Copy link
Contributor

maxme commented Aug 28, 2015

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.