New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/3039-fab-position #3111

Merged
merged 1 commit into from Aug 27, 2015
Jump to file or symbol
Failed to load files and symbols.
+17 −12
Diff settings

Always

Just for now

Wrap the My Site FAB in a CoordinatorLayout, let the FAB handle eleva…

…tion
  • Loading branch information...
nbradbury committed Aug 27, 2015
commit d34605eedbb317064949f3e011c8cee8f136f84f
@@ -385,16 +385,22 @@
</LinearLayout>
<android.support.design.widget.FloatingActionButton
android:id="@+id/fab_button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end|bottom"
android:layout_marginBottom="@dimen/fab_margin"
android:layout_marginRight="@dimen/fab_margin"
android:src="@drawable/gridicon_create_light"
app:borderWidth="0dp"
app:elevation="@dimen/fab_elevation"
app:rippleColor="@color/fab_pressed" />
<!-- this coordinator is only here due to https://code.google.com/p/android/issues/detail?id=175330 -->
<android.support.design.widget.CoordinatorLayout
android:id="@+id/coordinator"
android:layout_width="match_parent"
android:layout_height="match_parent">
<android.support.design.widget.FloatingActionButton
android:id="@+id/fab_button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end|bottom"
android:layout_marginBottom="@dimen/fab_margin"
android:layout_marginRight="@dimen/fab_margin"
android:src="@drawable/gridicon_create_light"
app:borderWidth="0dp"
app:rippleColor="@color/fab_pressed" />
</android.support.design.widget.CoordinatorLayout>
</FrameLayout>
@@ -66,7 +66,6 @@
android:layout_marginRight="@dimen/fab_margin"
android:src="@drawable/gridicon_create_light"
app:borderWidth="0dp"
app:elevation="@dimen/fab_elevation"
app:rippleColor="@color/fab_pressed" />
</android.support.design.widget.CoordinatorLayout>
ProTip! Use n and p to navigate between commits in a pull request.