Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #967 resize picture for wpspan #977

Merged
merged 5 commits into from Feb 27, 2014

Conversation

Projects
None yet
2 participants
Contributor

daniloercoli commented Feb 25, 2014

@roundhill You're the master of WPSpan. Could you please take a look at this PR?

@roundhill roundhill self-assigned this Feb 25, 2014

getImageSize fails for images captured right from the camera. I think that is what the code at 9ac5d67#diff-4ef619f4d0edf31bd1c5faf4c5e09c71R527 was for. If the content query doesn't work, then we just get the image as a File.

Fix an issue where 'getImageSize' and 'createThumbnailFromUri' can't …
…access pictures captured right from the camera.
Contributor

daniloercoli commented Feb 27, 2014

@roundhill Fixed the issue where getImageSize can't access images captured right from the camera. I noticed that even createThumbnalFromUriwas suffering of the same issue and applied a fix on it. The code is now more legible.

Contributor

roundhill commented Feb 27, 2014

Works now! I'm noticing some warnings in Android Studio, mostly for redundant code and now unused methods. Are you still using eclipse? The code works fine but it'd be nice to clean those up.

Contributor

daniloercoli commented Feb 27, 2014

Yes, I'm still using Eclipse. If it's easy for you can remove those methods.

roundhill added a commit that referenced this pull request Feb 27, 2014

@roundhill roundhill merged commit d98266f into develop Feb 27, 2014

@roundhill roundhill deleted the issue/967-resize-image-wpspan branch Feb 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment