Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats - File downloads endpoint #1352

Merged
merged 13 commits into from Aug 22, 2019

Conversation

@planarvoid
Copy link
Contributor

commented Aug 19, 2019

This PR adds an endpoint for the File downloads block in stats. It should be reviewed with the related WPAndroid PR.

@planarvoid planarvoid requested a review from 0nko Aug 19, 2019
@planarvoid planarvoid self-assigned this Aug 19, 2019
planarvoid added 3 commits Aug 19, 2019
@planarvoid planarvoid referenced this pull request Aug 19, 2019
1 of 1 task complete
@planarvoid planarvoid requested review from khaykov and 0nko and removed request for 0nko and khaykov Aug 19, 2019
@0nko
0nko approved these changes Aug 20, 2019
Copy link
Contributor

left a comment

Looks great, there's just one minor nitpick. I'll test the changes on WPAndroid first and if everything's good I'll merge this PR.

}

suspend fun getPostDetailTypes(): List<PostDetailType> = withContext(coroutineContext) {
return@withContext listOf(

This comment has been minimized.

Copy link
@0nko

0nko Aug 20, 2019

Contributor

Nice!

@0nko 0nko self-assigned this Aug 20, 2019
planarvoid added 4 commits Aug 20, 2019
@0nko
0nko approved these changes Aug 22, 2019
Copy link
Contributor

left a comment

:shipit:

@0nko 0nko merged commit bfee025 into develop Aug 22, 2019
3 checks passed
3 checks passed
ci/circleci: Lint Your tests passed on CircleCI!
Details
ci/circleci: Mocked Connected Tests Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@0nko 0nko deleted the feature/file_downloads_endpoint branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.