Media uploading first fix #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxme
reviewed
Mar 17, 2017
| @@ -70,7 +70,7 @@ public MediaRestClient(Context appContext, Dispatcher dispatcher, RequestQueue r | |||
| super(appContext, dispatcher, requestQueue, accessToken, userAgent); | |||
| mOkHttpClient = okClientBuilder | |||
| .connectTimeout(BaseRequest.DEFAULT_REQUEST_TIMEOUT, TimeUnit.MILLISECONDS) | |||
| .readTimeout(BaseRequest.DEFAULT_REQUEST_TIMEOUT, TimeUnit.MILLISECONDS) | |||
| .readTimeout(BaseRequest.DEFAULT_REQUEST_READ_TIMEOUT, TimeUnit.MILLISECONDS) | |||
There was a problem hiding this comment.
Can you rename this DEFAULT_REQUEST_READ_TIMEOUT to UPLOAD_REQUEST_READ_TIMEOUT, and also reuse it in MediaXMLRPCClient?
|
Renamed and used in both the REST and XML-RPC clients. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #370 by setting the read_timeout to 60secs.
Not sure how you can reproduce the issue, but you could try by uploading big pictures or videos to your dotcom blog. All the details in the ticket.