Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Start: Dismiss Notices using clearWithTag #11394

Open
shiki opened this issue Apr 2, 2019 · 3 comments · May be fixed by #12780

Comments

@shiki
Copy link
Member

@shiki shiki commented Apr 2, 2019

In #11281, we added the ability to dismiss Notices using tags:

ActionDispatcher.dispatch(NoticeAction.clearWithTag(noticeTag))

Using NoticeAction.clearWithTag is preferred to NoticeAction.dismiss. The .clearWithTag helps in avoiding dismissing Notices that the current page did not create.

In #11281, we only changed QuickStartTourGuide to use .dismiss. This can be improved to use .clearWithTag.

@Reza-Rajabi

This comment has been minimized.

Copy link

@Reza-Rajabi Reza-Rajabi commented Oct 26, 2019

Hi,
Let me try this one. Thanks.

Reza-Rajabi added a commit to Reza-Rajabi/WordPress-iOS that referenced this issue Oct 27, 2019
@Reza-Rajabi Reza-Rajabi linked a pull request that will close this issue Oct 27, 2019
@Reza-Rajabi

This comment has been minimized.

Copy link

@Reza-Rajabi Reza-Rajabi commented Oct 28, 2019

I have made a pull request, and I am wondering if I could have a review/ feedback ...

@shiki

This comment has been minimized.

Copy link
Member Author

@shiki shiki commented Oct 28, 2019

Thank you, @Reza-Rajabi. We'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.