Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Zendesk SDK to 3.0.0 #12107

Closed
jkmassel opened this issue Jul 11, 2019 · 8 comments · Fixed by #12264

Comments

@jkmassel
Copy link
Contributor

commented Jul 11, 2019

Currently, the Zendesk SDK is at version 2.3.1.

There's a new major version available at: https://github.com/zendesk/zendesk_sdk_ios/releases/tag/3.0.0

It appears to be bug fix release made backwards-incompatible by the addition of another required library.

This is a technical debt task. At this point, we'd like to scope it out for possible inclusion in groundskeeping. It's marked as medium priority because we need to stay on top of these SDK changes until they're no longer tied to a specific Xcode version.

@frosty

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

I just tested updating the pod to 3.0.1, and I don't see any issues – it just seems to work. Is there any reason we shouldn't just do this? Without adding any imports for the new library it just seems to work. Could be because we're not using the UiConfiguration class directly?

@designsimply designsimply moved this from To Do to Prioritized iOS in Groundskeeping Jul 30, 2019

@jkmassel

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

If we have the bandwidth to test it extensively this cycle, we could include it in 13.0. In the past, things have broken when we upgraded the SDK, even just between minor versions, so I'd just want to be really sure it'll be stable :)

@designsimply – WDYT?

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@jkmassel the biggest concern at the moment is helping unblock users who have reported not being able to use the Contact Us form. It sounds to me like we don't really have a lock on whether an SDK update will do that yet (we need more reports/more data/more steps to reproduce for that case). Because of that, I don't think it's urgent enough to push into 13.0 but would like to get something on the roadmap to update the Zendesk SDK before iOS 13 comes out because it will likely help us to be on the latest SDK when we want to test the next Zendesk SDK release for iOS 13 compatibility.

Moved this to the Prioritized iOS list in Groundskeeping because if it can be done within a maintenance rotation then it will help move other issues forward. If it cannot, then I will recommend making it a project for a product team instead of trying to tackle it as maintenance where the amount of time and number of people is a bit more limited.

Another possibility would be to start a project to switch from using the Zendesk SDK to the Zendesk API by building our own integration.

Possibly related: #12145

@frosty

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Fwiw, when testing with 3.0.1 I was still getting a crash when trying to add media to a ticket from my camera or device media library (the small selection of recent media worked fine though).

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@frosty your comment led me to figure out some solid testing steps for the crash report at #11397 🎉 and I left a comment at #11397 (comment) with testing steps and notes.

@jkmassel as discussed on Slack, we'll go ahead and update from Zendesk SDK 2.3.1 to 3.0.1 and add a line item to the WPiOS 13.0 call for testing to make sure it gets tested—internally only though because we don't want to clobber people with Testflight updates and the plan is to revert if we find an unreasonable amount of breakage in the Profile > Help & Support > Contact Us screen.

@designsimply designsimply moved this from Prioritized iOS to In Progress in Groundskeeping Aug 1, 2019

@designsimply designsimply assigned jkmassel and unassigned ScoutHarris Aug 1, 2019

@danielebogo danielebogo referenced this issue Aug 2, 2019
0 of 1 task complete

Groundskeeping automation moved this from In Progress to Done Jul 29-Aug 2, 2019 Aug 6, 2019

danielebogo added a commit that referenced this issue Aug 6, 2019
Merge pull request #12264 from /issues/12107-update-zendesk
[Zendesk] Update SDK to version 3.0.1
@charliescheer

This comment has been minimized.

Copy link

commented Aug 7, 2019

Responding to 2258325-zen per the message we received

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Noting this was tested as part of 13.0 beta testing but still needs further testing.

(internal reference: p5T066-XE-p2#comment-3346)

@designsimply

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.