Domains - TabBar has a transparent background in the detail screen when using Dark Mode

[geriux]

In trunk the TabBar does not have a background when using the app in Dark Mode and accessing the Domain's detail screen.

Expected behavior

The TabBar should have a background in Dark mode

ScreenRecording_08-13-2024.15-18-47_1.MP4

Actual behavior

The TabBar has a transparent background

ScreenRecording_08-13-2024.15-13-39_1.MP4

Steps to reproduce the behavior

• Open the app
• Go to "Me" in the TabBar
• All Domains
• Open a Domain

Tested on Simulator/iPhone 15 Pro, iOS 17/18.1, Jetpack iOS (trunk)

[dangermattic]

Thanks for reporting! 👍

[geriux]

Hey @kean 👋 I know you've worked recently on some changes related to the navigation. Could this be related?

[kean]

Nice catch. Thanks for reporting it. I'll address it shortly.

[kean]

Fixed in #23495.

Btw, I'm not sure how you got it to work because this page always redirects me to the standalone Safari because of this code:

            if !self.shouldAllowNavigation(for: url) {
                // Open URL in device browser then go back to Domain Management page.
                self.open(url)
                self.goBack()
            }

It was broken for me since the introduction, so its an existing bug.

[geriux]

Btw, I'm not sure how you got it to work because this page always redirects me to the standalone Safari because of this code:

Interesting, I was able to access all of my domains 😅