We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In trunk the TabBar does not have a background when using the app in Dark Mode and accessing the Domain's detail screen.
trunk
The TabBar should have a background in Dark mode
The TabBar has a transparent background
The text was updated successfully, but these errors were encountered:
Thanks for reporting! 👍
Sorry, something went wrong.
Hey @kean 👋 I know you've worked recently on some changes related to the navigation. Could this be related?
Nice catch. Thanks for reporting it. I'll address it shortly.
Fixed in #23495.
Btw, I'm not sure how you got it to work because this page always redirects me to the standalone Safari because of this code:
if !self.shouldAllowNavigation(for: url) { // Open URL in device browser then go back to Domain Management page. self.open(url) self.goBack() }
It was broken for me since the introduction, so its an existing bug.
Interesting, I was able to access all of my domains 😅
kean
Successfully merging a pull request may close this issue.
In
trunk
the TabBar does not have a background when using the app in Dark Mode and accessing the Domain's detail screen.Expected behavior
The TabBar should have a background in Dark mode
ScreenRecording_08-13-2024.15-18-47_1.MP4
Actual behavior
The TabBar has a transparent background
ScreenRecording_08-13-2024.15-13-39_1.MP4
Steps to reproduce the behavior
Tested on Simulator/iPhone 15 Pro, iOS 17/18.1, Jetpack iOS (trunk)
The text was updated successfully, but these errors were encountered: