Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue/10623 add dependency attribution #11776
This fix implements the great suggestion from @jtreanor to convert the 3rd-party acknowledgements markdown created for us by CocoaPods into HTML and then display that in a web view. Using the commonmarker gem, we convert the markdown to HTML during the
Unit tests in Xcode (Product > Test) passed.
Expect: A list of licenses for third-party libraries we use. Content should be identical to Pods/Target Support Files/Pods-WordPress/Pods-WordPress-acknowledgements.markdown
Update release notes:
For the rendering of the HTML, just a few small changes to make the text on the page more easily readable. Apologies for not including these details on the original ticket.
jtreanor left a comment •
Having a margin on all sides makes sense!
The text on the screen is still rendering quite small. @markpar could you try 2xing it 32 and see what that looks like?
Sure thing, @megsfulton!
I'm wondering if this might be an issue with the iPhone simulator? It appears not to be rendering this web view content correctly, perhaps? My hypothesis is that your initial
@jtreanor, what are your thoughts on how to proceed? I am searching the internets to see if this might be a known issue with WKWebView and local HTML content, and am continuing my attempts to deploy to my physical iPhone.
Turns out the iPhone simulator is, of course, not the problem at all.
After that, there was a single problem child that remained. The license for
Once that was taken care of, I added a