Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Extension: Remove the restriction on number of images shared #11780

Merged
merged 3 commits into from May 30, 2019

Conversation

@nheagy
Copy link
Contributor

commented May 24, 2019

Refs #9335

Improvements in #11626 and #11740 should now allow a large number of images to be shared without any memory issues or broken image URLs. I made an example post with fifteen images.

To test:

  • Build, and share more than three images with the share extension(s)
  • Publish
  • Ensure the post has all the images

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@nheagy nheagy added this to the 12.6 milestone May 24, 2019

@nheagy nheagy requested a review from bummytime May 24, 2019

@nheagy nheagy self-assigned this May 24, 2019

@nheagy nheagy requested review from SergioEstevao and removed request for bummytime May 28, 2019

@SergioEstevao
Copy link
Contributor

left a comment

Working great! :shipit:

@nheagy nheagy merged commit e4cd2bb into develop May 30, 2019

2 of 3 checks passed

ci/circleci: build_and_test CircleCI is running your tests
Details
Hound No violations found. Woof!
Peril All green. Yay.
Details

@nheagy nheagy deleted the issues/9335-support-sharing-many-images branch May 30, 2019

@nheagy

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Thanks @SergioEstevao!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.