Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Updated reply and edit comment messaging experience #11817
This PR only updates the experience of messaging the failure in uploading an edit to a comment or a reply to a comment and does not deal with the reported failure to upload the comment completely.
Instead of showing an alert with confusing options to try again (which didn't do anything) or to cancel (which dismissed the alert)
Hopefully the failed upload of the comment/reply can be automatically triggered in the future with the upcoming addition of the upload manager
Update release notes:
shiki left a comment
Thank you for working on this, @yaelirub. I'm requesting changes here because of the
There are opportunities for improvements in the UI.
The message disappears as soon as the I hit Reply
Very long response time
On a very bad connection, it takes a while to receive an error or success message. On this GIF, it takes roughly 1 minute before I received a response.
These are scary behaviors. As a user, I'm not sure if something is happening in the background. If there was an error, I could not even get my message back. It is probably not trivial to fix these. Should we make this part of the Offline Support project? Or is it out of scope?
For now, what do you think about these?
@osullivanchris, perhaps you'd like to chime in on this as well.
So weird. I wrote a comment while I was at the airport and I can't see it here. I guess Github has there own issues on low connectivity :P
I'm not sure about this. The way we use notices in the app is to notify when an action was successful or not and not that we are preforming an action so it doesn't feel aligned.
Hmm, yeah. That makes sense.
Hey @shiki , I updated the PR to show notices on success or failure of a reply.
May 31, 2019