Join GitHub today
remove blocking spinner on upload and autosave before preview #12031
As described in the issue when saving a draft or autosaving a post before preview we used to show a blocking spinner which would block the user from performing any actions till preview is generated.
This PR aims to improve the experience by showing the saving/generating status in the navigation bar the same way we do when uploading media.
This improvement brings up the need to also remove the blocking spinner when loading the preview (web view loading). It will be tackled in a separate PR
Update release notes:
jklausa left a comment
I will update the code to fix this. Wish we were using autolayout there.
It will be solved in a future PR. Thanks for mentioning though.
Hey I think these concerns from @jklausa are totally valid! I thought it was effective to grab something for free here to unblock us. But if I was designing this pattern from scratch that's not the way I would do it. I actually don't know if I've seen that in any app before :D
It depends whether we think there is value in creating a new pattern for non-blocking loading indication. I'd be happy to take a look at it, but perhaps it should be a separate issue?
@jklausa , I have created a new view LoadingStatusView that is meant to replace the WPUplaodStatusButton.
I tested this in English and Hebrew.
Please test like you did before and let me know what you think.
If it seems good to you I can open another PR to replace WPUplaodStatusButton with LoadingStatusView
shiki left a comment •
Previewing may cause drafts to be published