Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue with the tour guide not initializing some values in time. #12051

Conversation

@diegoreymendez
Copy link
Contributor

commented Jul 2, 2019

Fixes #11687

This PR also fixes two issues that could cause the spotlight effect to never go away:

  1. If we run the "Upload an Icon" tutorial multiple times in a row without ever tapping the icon.
  2. If we run the "Upload an Icon" tutorial and then a different one without ever tapping on the icon.

Testing:

  1. Create a WP.com site.
  2. When offered to, request assistance to set the site up.
  3. Make sure the spotlight dot effect is visible when the "Upload an Icon" tutorial is running.
  4. Try multiple combinations of running "Upload an Icon" tutorial multiple times in a row with and without tapping on the icon. Make sure it behaves well.
  5. Try multiple combinations of running "Upload an Icon" tutorial and other tutorials multiple times in a row with and without tapping on the icon. Make sure it behaves well.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@diegoreymendez diegoreymendez requested a review from nheagy Jul 2, 2019

@diegoreymendez diegoreymendez self-assigned this Jul 2, 2019

@diegoreymendez diegoreymendez added this to In Progress in Improve Site Creation v2 [iOS] via automation Jul 2, 2019

@diegoreymendez diegoreymendez moved this from In Progress to In Review in Improve Site Creation v2 [iOS] Jul 2, 2019

@diegoreymendez diegoreymendez modified the milestones: 12.7 ❄️, 12.9 Jul 2, 2019

@nheagy
Copy link
Contributor

left a comment

Hi @diegoreymendez thanks for tackling this one.

I left some comments, as I think this can be simplified. I think making immediately always false will work fine 😀

@diegoreymendez diegoreymendez requested a review from nheagy Jul 4, 2019

@nheagy

nheagy approved these changes Jul 4, 2019

Copy link
Contributor

left a comment

Looks great!

:shipit:

@diegoreymendez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@nheagy - Ready for another look.

@diegoreymendez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Oh nm, I missed the approval. Thanks for the review!

@diegoreymendez diegoreymendez merged commit 98719ed into develop Jul 4, 2019

3 checks passed

Hound No violations found. Woof!
Peril All green. Good on 'ya.
Details
ci/circleci: build_and_test Your tests passed on CircleCI!
Details

Improve Site Creation v2 [iOS] automation moved this from In Review to Done (PRs) Jul 4, 2019

@diegoreymendez diegoreymendez deleted the issue/11687-blue-dot-not-showing-for-icon-change-tutorial-step branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.