Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue that was causing new site previews to show behind the "Done" button. #12052

Merged

Conversation

@diegoreymendez
Copy link
Contributor

commented Jul 2, 2019

Fixes #12046

In the last step of the Site Creation flow, the preview is no longer being laid out behind the "Done" button.

Testing:

Please test in both iPhone and iPad.

  1. Go to the list of sites.
  2. Create a new WP.com site.
  3. Fill out all of the required information, and reach the last step (site preview).
  4. Make sure you can scroll all the way down to the bottom of the site and that the site doesn't finish behind the "Done" button.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@diegoreymendez diegoreymendez requested review from danielebogo and yaelirub Jul 2, 2019

@diegoreymendez diegoreymendez self-assigned this Jul 2, 2019

@diegoreymendez diegoreymendez added this to In Review in Improve Site Creation v2 [iOS] via automation Jul 2, 2019

@diegoreymendez diegoreymendez added this to the 12.7 ❄️ milestone Jul 2, 2019

@diegoreymendez diegoreymendez requested review from aerych and removed request for danielebogo Jul 2, 2019

@diegoreymendez diegoreymendez modified the milestones: 12.7 ❄️, 12.9 Jul 2, 2019

@aerych

aerych approved these changes Jul 2, 2019

Copy link
Member

left a comment

Tested with the iPhone X and iPad Pro 9.7 simulators. Confirming the scrollable area stops at the done button vs running behind it. Cheers @diegoreymendez :) :shipit:

@yaelirub
Copy link
Contributor

left a comment

Tested on iPhone Xs and iPad pro 12.9 confirmed that it works as expected. 👍

@diegoreymendez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Thanks!

@diegoreymendez diegoreymendez merged commit ab20dcd into develop Jul 2, 2019

3 checks passed

Hound No violations found. Woof!
Peril All green. Congrats.
Details
ci/circleci: build_and_test Your tests passed on CircleCI!
Details

Improve Site Creation v2 [iOS] automation moved this from In Review to Done (PRs) Jul 2, 2019

@diegoreymendez diegoreymendez deleted the issue/12046-preview-laid-out-behind-done-button branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.