Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/12267 draft publish action #12273

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@frosty
Copy link
Contributor

commented Aug 5, 2019

Fixes #12267. This PR adds a 'Publish Now' action for drafts in the posts list, accessible from the ... menu. It also removes the Stats item from that menu for drafts, as it doesn't make sense to be there.

before-after-draft-actions

To test:

  • Build and run, navigate to the Posts list
  • Choose Drafts
  • Ensure that the ... menu doesn't show a Stats item, and does show a Publish Now item.
  • Try publishing a post using the Publish Now action.
  • Ensure the Published, Scheduled, and Trash lists still contain the expected actions.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@frosty frosty added this to the 13.1 milestone Aug 5, 2019

@frosty

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@frosty frosty requested review from danielebogo and SylvesterWilmott Aug 5, 2019

@danielebogo
Copy link
Contributor

left a comment

LGTM! I made some test creating some post with different status and it worked as expected.
:shipit:

@SylvesterWilmott

This comment has been minimized.

Copy link

commented Aug 6, 2019

Looks good! Thanks @frosty

@frosty frosty merged commit 4676dd2 into develop Aug 6, 2019

3 checks passed

Hound No violations found. Woof!
Peril All green. Yay.
Details
ci/circleci: build_and_test Your tests passed on CircleCI!
Details

@frosty frosty deleted the issue/12267-draft-publish-action branch Aug 6, 2019

@charliescheer

This comment has been minimized.

Copy link

commented Aug 6, 2019

Looks great! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.