Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Fix formatted date when timezone is different #12363

Merged
merged 4 commits into from Aug 23, 2019

Conversation

@danielebogo
Copy link
Contributor

commented Aug 22, 2019

Fixes #12348

This PR fixes the problem with the formatted date when the Site timezone is different from the device timezone.

CC. @rachelmcr @elibud @jkmassel

To test:

  • Set your site timezone to a timezone other than UTC. Choose a timezone that, if you add your device timezone to it, the date will be different.
  • Check your stats in the app. Note that it now shows the right date for your site timezone setting.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@danielebogo danielebogo added this to the 13.1 ❄️ milestone Aug 22, 2019

@danielebogo danielebogo requested review from frosty and ScoutHarris Aug 22, 2019

@danielebogo danielebogo self-assigned this Aug 22, 2019

@danielebogo danielebogo added this to In progress in Full Stats Refresh via automation Aug 22, 2019

@ScoutHarris
Copy link
Contributor

left a comment

LGTM! Thanks!!

:shipit:

Full Stats Refresh automation moved this from In progress to Reviewer approved Aug 22, 2019

@danielebogo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Thanks @ScoutHarris

@frosty
frosty approved these changes Aug 23, 2019
Copy link
Contributor

left a comment

Seems to be working for me!

@danielebogo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Thanks @frosty

@danielebogo danielebogo merged commit c6e5cfc into release/13.1 Aug 23, 2019

6 checks passed

Hound No violations found. Woof!
Peril All green. Congrats.
Details
ci/circleci: Build UI Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad 6th generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone Xs) Your tests passed on CircleCI!
Details
ci/circleci: build_and_test Your tests passed on CircleCI!
Details

Full Stats Refresh automation moved this from Reviewer approved to Done Aug 23, 2019

@danielebogo danielebogo deleted the fix/stats-timezone branch Aug 23, 2019

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

LGTM! Dropping in a screenshot for reference:

stats-timezone-offset

Tested with WPiOS 13.2-beta1 (TestFlight) on iPhone 6S iOS 13.1 Beta 1 in Dark Mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.