Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Gutenberg DarkMode #12379
PR for Gutenberg DarkMode
All these will be worked on, on future PRs.
Test for a solved crash:
frosty left a comment
This is looking really good! I know you identified the toolbar as not being correctly coloured yet, but I also noticed one or two other things:
I think the deselected block movement icons are too faint – it's hard to make them out against the background. Also, in Thomas's original mockups the selected ones are a light grey instead of blue:
If possible, I think it'd be good if image placeholders and dimmed out uploading images were dark too – but this might need to wait for a future PR depending on complexity:
Thank you for the review @frosty !
Yes, those issues with the toolbar button colors are the ones I was referring too. It will take some refactoring on the JS side to make the proper change, so the idea is to handle that on another PR.
Good catch! And I agree that it's better for a future PR too.
Aug 26, 2019
6 checks passed
Agreed, this is looking really solid for the first version! I made some notes over the weekend of things I noticed on the design side, some of which you've already identified. I'd like to get these into the mix as quickly as possible, but I'll order based on "importance" from my POV:
And as @frosty noted:
I agree, we should lighten these up. When we update those icon colors in general, let's make the disabled style color ==