Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark mode] Fix iPad split view appearance #12521

Merged
merged 2 commits into from Sep 20, 2019

Conversation

@frosty
Copy link
Contributor

commented Sep 19, 2019

Fixes an issue that @rachelmcr discovered with the split view on iPads in dark mode. I don't think this entirely fixes the underlying issue, but it does resolve it for now. Really, we need to re-do the splitview implementation at some point.

I also resolved an issue where the status bar text color was dark instead of light.

ipad-dark

To test:

  • Build and run on iPad, iOS 13
  • Launch the app to a view like Me
  • Enter iPad multitasking (on the simulator, hold Cmd+shift and double-tap H)
  • Select another app
  • Enter multitasking again
  • Select WordPress
  • Before this patch, the detail pane would switch into dark mode.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@frosty frosty added this to the 13.2.xx ❄️ milestone Sep 19, 2019
@frosty frosty requested review from danielebogo and jkmassel Sep 19, 2019
Copy link
Contributor

left a comment

I tried a couple of different things but couldn't entirely repro the original issue on a physical iPad or in the simulator – my status bar colour was consistently wrong afterwards though.

Testing this branch fixed the status bar issue I was seeing, so I'm comfortable shipping it. WDYT?

Copy link
Contributor

left a comment

LGTM! I can't reproduce the bug anymore running this fix! Well done!
:shipit:

@frosty frosty merged commit 1db60f4 into release/13.2.xx Sep 20, 2019
6 checks passed
6 checks passed
Hound No violations found. Woof!
Peril All green. Well done.
Details
ci/circleci: Build UI Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 6th generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: build_and_test Your tests passed on CircleCI!
Details
@frosty frosty deleted the fix/ipad-split-view-dark-mode branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.