Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark Mode] General Improvements #12560

Merged
merged 7 commits into from Sep 27, 2019

Conversation

@danielebogo
Copy link
Contributor

commented Sep 26, 2019

Refs. #12320

This PR fixes some color for:
• Edit comment is white text on white background.
• Pending comments have a white background. / Comment moderation has incorrect background on the comment cell, screenshot added to the thread.
• Gravatar cropping screen has a white background

dark-mode-comments-gravatar-dark
dark-mode-comments-gravatar-light

• Map in Stats DWMY: I changed the map fill color using .systemGray4 and fixed the stroke color
dark-mode-stats-map

To test:

• Run this branch with an iOS 13 device
• Open a comment in pending to check the colors and switch between light and dark mode
• Edit a comment to check the colors and switch between light and dark mode
• Open Stats->DWMY and scroll till the map to check the colors and switch between light and dark mode
• Tab Me, open on the user picture and its cropping screen to check the colors and switch between light and dark mode
• Test everything works with iOS 12

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@danielebogo danielebogo added this to the 13.4 milestone Sep 26, 2019
@danielebogo danielebogo requested review from frosty and mattmiklic Sep 26, 2019
@danielebogo danielebogo self-assigned this Sep 26, 2019
Copy link
Member

left a comment

Nice fixes here. One request; in this screenshot the color contrast is very low. Could you change the author name and comment text back to the text semantic color? This would make sure it works well in both light and dark mode.

@danielebogo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

@mattmiklic I replaced the labels text color
dark-mode-comments

Copy link
Member

left a comment

Thanks! Looks good now.

@frosty
frosty approved these changes Sep 26, 2019
Copy link
Contributor

left a comment

Fantastic! Great fixes, look good 👍

Don't forget to check the release notes checkbox – I guess we should just have a single general 'dark mode improvements' line in the release notes.

@danielebogo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

@danielebogo danielebogo merged commit 365b908 into develop Sep 27, 2019
6 checks passed
6 checks passed
Hound No violations found. Woof!
Peril All green. Congrats.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@danielebogo danielebogo deleted the fix/123020-dark-mode-improvements branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.