Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal links: If we don't match a URL, pop back to Safari #12575

Merged
merged 2 commits into from Sep 30, 2019

Conversation

@frosty
Copy link
Contributor

commented Sep 30, 2019

Fixes #12388.

Some of our universal links rules for WordPress.com capture URLs that we currently don't handle in the app. For example:

/post/* is used to open the editor for new posts for URLs like wordpress.com/post/mycoolsite.wordpress.com

Unfortunately, this also captures URLs we don't handle in the app, such as editing a specific post:

wordpress.com/post/mycoolsite.wordpress.com/123

We didn't implement handling for these URLs because we felt we couldn't be confident that the post exists in the app and that we have the latest version (the user could've already done some editing in Safari, potentially). However, our /post/* route matches this URL, so the app launches but we just silently do nothing.

This PR is a small tweak so if we launch due to a URL but it doesn't match any of our routes, we'll pop back out to Safari.

To test:

  • Build and run in the simulator
  • Launch the app / login
  • Background the app
  • In terminal, run:
xcrun simctl openurl booted https://wordpress.com/post/your-test-site-domain

and ensure that the editor opens for the correct site.

  • Background the app again, and now run:
xcrun simctl openurl booted https://wordpress.com/post/your-test-site-domain/123
  • The app should launch momentarily, and then jump back out to Safari. Before this PR, the app would launch and then just do nothing.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@frosty frosty added this to the 13.4 milestone Sep 30, 2019
@frosty frosty requested a review from danielebogo Sep 30, 2019
Copy link
Contributor

left a comment

LGTM!
Test ok with iOS 12 and 13!
:shipit:

@frosty frosty merged commit 2785da1 into develop Sep 30, 2019
6 checks passed
6 checks passed
Hound No violations found. Woof!
Peril All green. Well done.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@antons

This comment has been minimized.

Copy link

commented Oct 1, 2019

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.