[SIWA] Handle credential state changes #12585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosty
reviewed
Oct 1, 2019
| DDLogInfo("checkAppleIDCredentialState: Unauthorized Apple ID. User signed out.") | ||
| switch state { | ||
| case .revoked: | ||
| DDLogInfo("checkAppleIDCredentialState: Revoked Apple ID. User signed out.") | ||
| self?.logOutDefaultWordPressComAccount() |
There was a problem hiding this comment.
We should also ensure we delete the Apple ID from the keychain on log out. I noticed an issue with my device where it somehow still has the Apple ID in the keychain, even though I logged out and logged back in with a different account. Because of this, each time we do the apple credential state check here, the app sees I have a revoked ID and logs me out again.
There was a problem hiding this comment.
Hey @frosty . Nice catch! It has been done. See what you think now. Thanks!
frosty
approved these changes
Oct 2, 2019
ScoutHarris
deleted the
issue/12399-siwa_handle_credential_state_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12399
Related WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#139
This uses the WPAuth changes to:
CredentialStateprovided by WPAuth.revoked, log out of the account.There should be no visible difference from the previous implementation.
To test:
This should be tested on a real device for proper keychain handling.
Update release notes:
RELEASE-NOTES.txtif necessary.