Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark Mode ]NUX Button Loading #12610

Merged
merged 5 commits into from Oct 3, 2019

Conversation

@danielebogo
Copy link
Contributor

commented Oct 2, 2019

Fixes #140
Refs. #142

This PR update the WordPress Authenticator pod. The new version includes a fix where the NUX button activity indicator is visible in light/dark mode

dark-mode_nux-button-loading

To test:

  • Run this branch on iOS 13
  • If you are logged in sign out
  • From the login, use the WordPress login and add your email. Then press Next.
  • You should see the loader
  • run it on iOS 12 to see everything works fine

Podfile will be updated as soon #142 will be merged

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@danielebogo danielebogo added this to the 13.4 milestone Oct 2, 2019
@danielebogo danielebogo added this to In Review in Dark Mode via automation Oct 2, 2019
@danielebogo danielebogo requested a review from frosty Oct 2, 2019
@danielebogo danielebogo self-assigned this Oct 2, 2019
@danielebogo danielebogo marked this pull request as ready for review Oct 2, 2019
@frosty
frosty approved these changes Oct 2, 2019
Dark Mode automation moved this from In Review to Approved Oct 2, 2019
@danielebogo danielebogo merged commit d1e6ee9 into develop Oct 3, 2019
6 checks passed
6 checks passed
Hound No violations found. Woof!
Peril All green. Nice work.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
Dark Mode automation moved this from Approved to Done Oct 3, 2019
@danielebogo danielebogo deleted the fix/12320-nux-button-indicator branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dark Mode
  
Done
2 participants
You can’t perform that action at this time.