Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aztec options picker popover DarkMode #12616

Merged
merged 5 commits into from Oct 4, 2019

Conversation

@etoledom
Copy link
Contributor

commented Oct 3, 2019

Fixes #12320 (comment)

aztec-picker

Related Aztec PR: wordpress-mobile/AztecEditor-iOS#1216

To test:

  • Run the project on iOS 13 using DarkMode.
  • Open Aztec.
  • Select a Header and a List option on the toolbar.
  • Check that the popover has a dark background.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@etoledom etoledom added this to the 13.4 milestone Oct 3, 2019
@etoledom etoledom requested review from frosty and danielebogo Oct 3, 2019
@etoledom etoledom self-assigned this Oct 3, 2019
@etoledom etoledom marked this pull request as ready for review Oct 3, 2019
@danielebogo danielebogo added this to In Review in Dark Mode via automation Oct 3, 2019
Dark Mode automation moved this from In Review to Approved Oct 3, 2019
Copy link
Contributor

left a comment

Thank you for fixing this!!!
:shipit:

etoledom added 2 commits Oct 4, 2019
@etoledom etoledom merged commit 349f40e into develop Oct 4, 2019
5 checks passed
5 checks passed
Peril All green. Congrats.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
Dark Mode automation moved this from Approved to Done Oct 4, 2019
@etoledom

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Thank you!

@etoledom etoledom deleted the issue/aztec-options-popover-darkmode branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dark Mode
  
Done
2 participants
You can’t perform that action at this time.