Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark Mode] Fix Reader Detail Like star animation background color #12637

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@frosty
Copy link
Contributor

commented Oct 7, 2019

Fixes #12603.

This PR updates the background color of the Like star animation in Reader detail to fix an issue where it was appearing as black.

Before:

like-before

After:

like-dark-mode

To test:

  • Build and run on iOS 13 and turn on dark mode
  • Navigate to a post in the reader
  • Tap the Like button and check the animation looks good
  • Double check it still looks okay in light mode

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@frosty frosty added this to the 13.4 milestone Oct 7, 2019
@frosty frosty added this to In Review in Dark Mode via automation Oct 7, 2019
Dark Mode automation moved this from In Review to Approved Oct 7, 2019
Copy link
Member

left a comment

:shipit:

@frosty frosty merged commit ee54875 into develop Oct 7, 2019
6 checks passed
6 checks passed
Hound No violations found. Woof!
Peril All green. Jolly good show.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
Dark Mode automation moved this from Approved to Done Oct 7, 2019
@frosty frosty deleted the issue/12603-like-star-dark-mode branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dark Mode
  
Done
2 participants
You can’t perform that action at this time.