Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment moderation on self-hosted sites #12910

Merged
merged 3 commits into from Nov 9, 2019

Conversation

@rachelmcr
Copy link
Member

rachelmcr commented Nov 8, 2019

Fixes #12909

Related WordPressKit PR: wordpress-mobile/WordPressKit-iOS#197

To test:

  1. Log in to a self-hosted site (without Jetpack).
  2. Open the My Sites tab.
  3. Open the Comments section.
  4. Select a pending comment.
  5. Tap "Approve" and confirm the comment is approved (doesn't revert to pending state).
  6. Tap "Unapprove" and confirm the comment is unapproved (doesn't revert to approved state).

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@rachelmcr rachelmcr added this to the 13.7 milestone Nov 8, 2019
@rachelmcr rachelmcr self-assigned this Nov 8, 2019
@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Nov 8, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@rachelmcr rachelmcr marked this pull request as ready for review Nov 8, 2019
@rachelmcr rachelmcr requested a review from aerych Nov 8, 2019
@aerych
aerych approved these changes Nov 8, 2019
Copy link
Member

aerych left a comment

Tested and worked perfectly. I left a tiny suggestion in the related WordPressKit PR. Otherwise this is good to go! :shipit:

@rachelmcr rachelmcr merged commit d84139e into develop Nov 9, 2019
7 checks passed
7 checks passed
Hound No violations found. Woof!
Peril All green. Good on 'ya.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: Installable Build/Hold Your job is on hold on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@rachelmcr rachelmcr deleted the issue/12909-self-hosted-comment-moderation branch Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.