Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Google 2FA login #13005
This uses the WPAuth changes to fix the Google 2FA login flow.
The flow that is fixed:
Since a refactor was needed, sanity check these cases to be sure I didn't break anything:
PR submission checklist:
frosty left a comment
Thanks for fixing this and for taking Woo into consideration! I left a few code comments. I tested the following cases:
All of these flows worked for me. However, when comparing to the existing app, I noticed one main difference – when I tap on Continue with Google, I no longer get pushed to the 'waiting for Google to complete' screen that I see on
This also means when I finish the Google web view portion of the login, I'm taken back to the opening NUX screen (with the animations) while the login completes in the background.
Google sign in never showed the loading view. Enabling the old login flow examples this.
It's happening on