Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIWA] Add flow for 2FA accounts #13013

Merged
merged 5 commits into from Dec 2, 2019
Merged

Conversation

@ScoutHarris
Copy link
Contributor

ScoutHarris commented Nov 27, 2019

Fixes #12477

WPKit PR: wordpress-mobile/WordPressKit-iOS#201
WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#158

This imports the WPKit & WPAuth changes to support signing in with SIWA 2FA accounts.

To test:

  • If you don't already have one, create an account using SIWA.
  • On the WordPress account in a browser, enabled Two-Step Authentication.
  • In the app, try to log in with that account using SIWA.
  • Verify you get prompted for a verification code, and you can log in.

verification_prompt

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 13.8 milestone Nov 27, 2019
@ScoutHarris ScoutHarris requested a review from frosty Nov 27, 2019
@ScoutHarris ScoutHarris self-assigned this Nov 27, 2019
@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Nov 27, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@loremattei loremattei mentioned this pull request Dec 2, 2019
loremattei added 2 commits Dec 2, 2019
@loremattei loremattei self-requested a review Dec 2, 2019
Copy link
Contributor

loremattei left a comment

As discussed with @frosty, I'm merging this PR in order to push it into the 13.8 code freeze.

@loremattei loremattei merged commit 9108b62 into develop Dec 2, 2019
7 checks passed
7 checks passed
Hound No violations found. Woof!
Peril All green. Jolly good show.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: Installable Build/Hold Your job is on hold on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@loremattei loremattei deleted the issue/12477-show_siwa_2fa_login branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.