Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new .org api client for Gutenberg networking #13020

Merged
merged 14 commits into from Mar 26, 2020

Conversation

koke
Copy link
Member

@koke koke commented Nov 28, 2019

See wordpress-mobile/WordPressKit-iOS#202 for description and testing instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke added [Status] DO NOT MERGE Network/Sync Gutenberg Editing and display of Gutenberg blocks. labels Nov 28, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 28, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@koke koke marked this pull request as ready for review December 12, 2019 11:57
@SergioEstevao SergioEstevao self-assigned this Feb 4, 2020
# Conflicts:
#	Podfile
#	Podfile.lock
#	WordPress/Classes/ViewRelated/Gutenberg/GutenbergNetworking.swift
# Conflicts:
#	Podfile
#	Podfile.lock
# Conflicts:
#	Podfile
#	Podfile.lock
@SergioEstevao SergioEstevao added this to the 14.5 milestone Mar 19, 2020
@SergioEstevao
Copy link
Contributor

@etoledom and @pinarol can you test/review this again? I think it's ready to merge now.

@loremattei loremattei modified the milestones: 14.5 ❄️, 14.6 Mar 23, 2020
@loremattei
Copy link
Contributor

Hey! I moved this PR to 14.6 as because 14.5 has been cut. If you want this to make it to 14.5, please feel free to ping me!

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/WordPressKit-iOS#202 (review). Looking great!

@SergioEstevao SergioEstevao changed the title [PoC] Use new .org api client for Gutenberg networking Use new .org api client for Gutenberg networking Mar 25, 2020
# Conflicts:
#	Podfile
#	Podfile.lock
And if not make sure completion object is called with failure.
@SergioEstevao SergioEstevao merged commit 6476e0e into develop Mar 26, 2020
@SergioEstevao SergioEstevao deleted the try/cookie-api-auth branch March 26, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Network/Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants