Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Time Widget] Add functionality #13043

Conversation

@ScoutHarris
Copy link
Contributor

ScoutHarris commented Dec 5, 2019

Fixes #13030

This adds full functionality to the All-Time widget. (And thus completes the #13030 effort.)

To test:


  • Start with a fresh install, or be logged out of the app.
  • Add the WordPress All-Time widget to your Today view.
    • Verify the unconfigured view is displayed.
    • Verify the widget cannot be expanded.
    • Verify tapping the widget launches the app.

unconfigured


  • Log into the app.
  • Go to Stats > Widgets > Use this site.
    • Verify the All-Time widget displays data for the selected site, and matches what is displayed in the app.
    • Verify the widget can be expanded/collapsed.

app

widget

widget_collapsed


  • Return to the app, and select a different site.
  • Go to Stats > Widgets > Use this site.
  • Verify the All-Time widget updates accordingly.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 13.9 milestone Dec 5, 2019
@ScoutHarris ScoutHarris requested a review from frosty Dec 5, 2019
@ScoutHarris ScoutHarris self-assigned this Dec 5, 2019
@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Dec 5, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

…ime_widget_functionality
@ScoutHarris ScoutHarris changed the base branch from feature/13030-all_time_widget_data to feature/13030-all_time_widget Dec 6, 2019
@frosty
frosty approved these changes Dec 6, 2019
Copy link
Contributor

frosty left a comment

Looking great! I ran through the tests, and everything worked as expected 👍

Just one thought – we probably need to update the unconfigured widget text for this one? It currently says:

"Display your site stats for today here"

Do we want something like "Display your all-time site stats here"?

@ScoutHarris

This comment has been minimized.

Copy link
Contributor Author

ScoutHarris commented Dec 6, 2019

Thanks @frosty ! The configure messages are now based on widget type.

configure

@frosty
frosty approved these changes Dec 6, 2019
@ScoutHarris ScoutHarris merged commit 30603da into feature/13030-all_time_widget Dec 6, 2019
3 of 4 checks passed
3 of 4 checks passed
ci/circleci: Build Tests CircleCI is running your tests
Details
Hound No violations found. Woof!
Peril All green. Jolly good show.
Details
ci/circleci: Installable Build/Hold Your job is on hold on CircleCI!
Details
@ScoutHarris ScoutHarris deleted the feature/13030-all_time_widget_functionality branch Dec 6, 2019
@ScoutHarris ScoutHarris mentioned this pull request Dec 6, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.