Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting: Adds fullscreen commenting #13112

Conversation

@emilylaguna
Copy link
Contributor

emilylaguna commented Dec 15, 2019

Depends on #13111
Fixes #12918 subtask: Add ability to go fullscreen while commenting

To test:

  1. Enter any comment flow (reader, notification, comments)
  2. Enter some text
  3. Tap the full screen toggle button
  4. Enter some more text
  5. Hit the exit fullscreen button
  6. Enter some more text
  7. Tap the reply/save button

Video Demos

Device Version Link
iPhone 8 11.4 https://www.dropbox.com/s/eowzknqz3u6vsb1/iPhone%208%20-%2011.4%20-%20Fullscreen%20Demo.mov?dl=0
iPhone 8 12.4 https://www.dropbox.com/s/qcly3q1eer355e5/iPhone%208%20-%2012.4%20-%20Fullscreen%20Demo.mov?dl=0
iPhone 8 13.4 https://www.dropbox.com/s/limjqdt2g9k59d1/iPhone%208%20-%2013.3%20-%20Fullscreen%20Demo.mov?dl=0
iPhone 11 Pro Max 13.3 https://www.dropbox.com/s/u897sver579actf/iPhone%2011%20Pro%20Max%20-%2013.3%20-%20Fullscreen%20Demo.mov?dl=0
iPad Air 11.4 https://www.dropbox.com/s/qgbpl41s1br2z7d/iPhone%20Air%20-%2011.4%20-%20Fullscreen%20Demo.mov?dl=0
iPad Air 12.4 https://www.dropbox.com/s/hh9rn88jb5jgfs5/iPhone%20Air%20-%2012.4%20-%20Fullscreen%20Demo.mov?dl=0
iPad Air 13.3 https://www.dropbox.com/s/mwxwpieo9bxhgd7/iPhone%20Air%20-%2013.3%20-%20Fullscreen%20Demo.mov?dl=0

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Dec 15, 2019

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@leandroalonso leandroalonso modified the milestones: Pending, 14.0 Dec 17, 2019
@leandroalonso leandroalonso merged commit 09339bc into wordpress-mobile:develop Dec 17, 2019
6 checks passed
6 checks passed
Hound No violations found. Woof!
Peril Found some issues. Don't worry, everything is fixable.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.