Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Insights tweaks – default cards, modal presentation #13131

Merged
merged 4 commits into from Dec 20, 2019

Conversation

@frosty
Copy link
Contributor

frosty commented Dec 17, 2019

Fixes #13127. This PR makes a few updates to Stats Insights:

  • The default set of cards has now been updated to match the issue linked above.
  • The Add stats card view is now presented modally instead of pushed

Default cards

Simulator Screen Shot - iPhone 11 - 2019-12-17 at 17 28 58

Modal presentation

Simulator Screen Shot - iPhone 11 - 2019-12-17 at 17 29 02

To test:

  • Build and run
  • With a site you haven't accessed before or modified insights, check that the default insights list is:
    • Latest Post Summary
    • Today
    • All-Time
    • Follower Totals
  • Tap Add stats card and check that the view is presented modally and still functions as expected.
  • Also test on iPad

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@frosty frosty added this to the 14.0 milestone Dec 17, 2019
@frosty frosty requested a review from ScoutHarris Dec 17, 2019
@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Dec 17, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

ScoutHarris left a comment

Looks good! Thanks for doing this!

:shipit:

@frosty

This comment has been minimized.

Copy link
Contributor Author

frosty commented Dec 17, 2019

Thanks @ScoutHarris!

@SylvesterWilmott Does this look ok to you too?

@SylvesterWilmott

This comment has been minimized.

Copy link

SylvesterWilmott commented Dec 18, 2019

Looks good, thanks @frosty

@frosty frosty merged commit ff8ec4f into develop Dec 20, 2019
7 checks passed
7 checks passed
Hound No violations found. Woof!
Peril All green. Nice work.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: Installable Build/Hold Your job is on hold on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@frosty frosty deleted the issue/13127-stats-tweaks branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.