Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when tapping on certain notifications #13158

Merged
merged 4 commits into from Dec 26, 2019

Conversation

@diegoreymendez
Copy link
Contributor

diegoreymendez commented Dec 26, 2019

This PR brings this fix sent to develop to the release/13.9 branch.

Description:

Fixes crash when the App is launched by certain notifications after being inactive.

Fixes #12669

Before Testing:

You'll need to enable push notifications for our development environment. This can be done by logging into your WordPress Sandbox, and running these commands:

cd /home/wpcom/public_html/bin/mobile-push-notification
svn up
php push-notifications-server.php -type=push -qi=10 -app_id=5

Reproducing the original issue:

Just run the testing steps below in our develop branch and you should see an exception being raised.

Testing:

  1. Make sure push notifications are running for our dev environment (see "Before Testing").
  2. Run the App.
  3. Immediately send it to brackground.
  4. Comment with another user in one of your test blogs so that a notification is sent to your device.
  5. Tap on the notification.

The notification should be opened correctly, and the App should not crash.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Dec 26, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@diegoreymendez diegoreymendez changed the base branch from develop to release/13.9 Dec 26, 2019
@diegoreymendez

This comment has been minimized.

Copy link
Contributor Author

diegoreymendez commented Dec 26, 2019

Copy link
Contributor

jleandroperez left a comment

:shipit:

@diegoreymendez diegoreymendez changed the title Issue/13155 crash in notifications Crash when tapping on certain notifications Dec 26, 2019
@diegoreymendez diegoreymendez merged commit 34990a7 into release/13.9 Dec 26, 2019
7 checks passed
7 checks passed
Hound No violations found. Woof!
Peril All green. Good on 'ya.
Details
ci/circleci: Build Tests Your tests passed on CircleCI!
Details
ci/circleci: Installable Build/Hold Your job is on hold on CircleCI!
Details
ci/circleci: UI Tests (iPad Air 3rd generation) Your tests passed on CircleCI!
Details
ci/circleci: UI Tests (iPhone 11) Your tests passed on CircleCI!
Details
ci/circleci: Unit Tests Your tests passed on CircleCI!
Details
@diegoreymendez diegoreymendez deleted the issue/13155-crash-in-notifications branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.