Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Stats: restore selected site ID when widget Stats modal is dismissed #13195
The problem was that the site ID used for stats was being overwritten by the site ID from the widget. To resolve this, the selected site ID is restored when the widget's Stats modal is dismissed. The Stats view is then refreshed for the correct site ID.
PR submission checklist:
bjtitus left a comment
Seems to behave as expected.
Out of scope: I wonder if we could remove the flash of the old stats by triggering a query refresh earlier. Also still trying to wrap my head around the singleton usage. I feel like the
Thanks @bjtitus .
Yea, I wasn't real happy with it showing the widget stats then the selected site stats, but I wanted to get a fix out in the next release. I'll look at this a bit closer separately.