Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Widgets: localize display names #13247

Merged
merged 3 commits into from Jan 20, 2020

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Jan 18, 2020

Ref #12702

This localizes the Stats Widgets display names.

To test:
Since there aren't localizations yet (obviously), you can verify the widgets are using localized strings by altering the CFBundleDisplayName in their respective InfoPlist.strings file.

The CFBundleDisplayName is displayed:

  • In the widget list.
  • In the widget title.

Example with altered CFBundleDisplayName:

display_name

widget_list

widget_title

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 14.1 milestone Jan 18, 2020
@ScoutHarris ScoutHarris self-assigned this Jan 18, 2020
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris mentioned this pull request Jan 18, 2020
22 tasks
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the title change when changing the string from the InfoPlist.strings files.

:shipit:

@ScoutHarris ScoutHarris merged commit 6515da4 into develop Jan 20, 2020
@ScoutHarris ScoutHarris deleted the fix/12702-widgets_localize_display_names branch January 20, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants