Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Group block in production #13367

Closed
wants to merge 6 commits into from
Closed

Conversation

@jbinda
Copy link
Collaborator

jbinda commented Feb 4, 2020

Updates Gutenberg so the Group block is available in production.

Gutenberg PR: WordPress/gutenberg#20004

To test:

  • Run the app without metro running
  • Start a new post
  • Verify Group block is visible in the block picker
  • Select the Group block
  • Verify it is working as expected:
    • Try to break it
    • Use try portrait & landscape modes
    • Try nesting it more than expected
    • Check if the navigation button on FloatingToolbar works
    • Check if AppenderButton is visible when Group is selected
    • Check if AppenderButton is show as placeholder when Group is unselected
    • Check if AppenderButton open the Inserter after press (when Group block is empty and when it already has some nested blocks)
    • Move the block between other ones inside a Group and check it works correctly
    • Move the whole Group block between another Group blocks in RootList
    • Try to use Ungroup button on Toolbar
    • Remove the block
    • Add one again
  • Use DarkMode
  • Save as draft
  • Open your draft and check the Group block is shown correctly

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@jbinda jbinda self-assigned this Feb 4, 2020
@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Feb 4, 2020

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 21884. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile

This comment has been minimized.

Copy link

peril-wordpress-mobile bot commented Feb 5, 2020

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@jbinda

This comment has been minimized.

Copy link
Collaborator Author

jbinda commented Feb 6, 2020

Closed because it was opened just for testing purpose

@jbinda jbinda closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.