Skip to content

ULS Prologue button view: fix visual blur for iPad #15022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ScoutHarris wants to merge 9 commits into from
Closed

ULS Prologue button view: fix visual blur for iPad #15022

ScoutHarris wants to merge 9 commits into from

Conversation

@ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Sep 30, 2020

Ref: wordpress-mobile/WordPressAuthenticator-iOS#401
Auth PR: wordpress-mobile/WordPressAuthenticator-iOS#490

This uses the Auth changes to fix the visual blur on the Prologue buttons.

To test:

  • Run the app. Log out if necessary.
  • On the prologue, verify the blur behind the buttons extends the full width of the view.
Before After
prologue_before prologue_after

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added this to the 15.9 milestone Sep 30, 2020
@ScoutHarris ScoutHarris self-assigned this Sep 30, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 30, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris mentioned this pull request Sep 30, 2020
Merged
@ScoutHarris ScoutHarris marked this pull request as ready for review September 30, 2020 20:17
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 30, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

mindgraffiti
mindgraffiti approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ScoutHarris
Copy link
Contributor Author

ScoutHarris commented Oct 2, 2020

Closing this. Auth was updated with #15018.

@ScoutHarris ScoutHarris closed this Oct 2, 2020
@ScoutHarris ScoutHarris deleted the feature/use_prologue_button_blur_ipad branch October 2, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindgraffiti mindgraffiti mindgraffiti approved these changes

Assignees

@ScoutHarris ScoutHarris

Labels

iPad [Type] Enhancement

Projects

None yet

Milestone

15.9

Development

Successfully merging this pull request may close these issues.

3 participants

@ScoutHarris @mindgraffiti