Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment detail: fix crash when replying to a comment #16165

Merged
merged 1 commit into from Mar 26, 2021

Conversation

ScoutHarris
Copy link
Contributor

Fixes #n/a

This fixes a crash when replying to a comment from comment details.

To test:

  • Go to Comments.
  • Select a Comment.
  • Enter a reply and send.
  • Verify the app doesn't crash.
  • Return to the Comments list.
  • Verify your reply appears in the Comments list.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Member

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @ScoutHarris 👋
Looks good to me! Tested as described. There was no crash, and the new reply appeared in the list.
:shipit: !

@ScoutHarris ScoutHarris merged commit 5816017 into release/17.0 Mar 26, 2021
@ScoutHarris ScoutHarris deleted the fix/comment_reply_crash branch March 26, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants