Skip to content

Call AVCaptureSession startRunning from a background thread #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokagio merged 2 commits into from
Nov 24, 2022
Merged

Call AVCaptureSession startRunning from a background thread #19636

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f67531
Call `AVCaptureSession` `startRunning` from a background thread
mokagio Nov 22, 2022
09f44d8
Send QR code `AVCaptureSession` interactions through serial queue
mokagio Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions WordPress/Classes/ViewRelated/QR Login/Helpers/QRLoginCameraSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ import AVFoundation

class QRLoginCameraSession: NSObject, QRCodeScanningSession {
var session: AVCaptureSession?
// > Delegate any interaction with the AVCaptureSession—including its inputs and outputs—to a
// > dedicated serial dispatch queue, so that the interaction doesn’t block the main queue.
// >
// > – https://developer.apple.com/documentation/avfoundation/capture_setup/avcam_building_a_camera_app
let sessionQueue = DispatchQueue(label: "qrlogincamerasession.queue.serial")

var cameraDevice: AVCaptureDevice?

var hasCamera: Bool {
Expand All @@ -24,21 +30,29 @@ class QRLoginCameraSession: NSObject, QRCodeScanningSession {
}

func start() {
session?.startRunning()
sessionQueue.async { [weak self] in
self?.session?.startRunning()
}
}

func stop() {
session?.stopRunning()
sessionQueue.async { [weak self] in
self?.session?.stopRunning()
}
}
}

private extension QRLoginCameraSession {
func startCameraSession() {
session?.startRunning()
sessionQueue.async { [weak self] in
self?.session?.startRunning()
}
}

func stopCameraSession() {
session?.stopRunning()
sessionQueue.async { [weak self] in
self?.session?.stopRunning()
}
}

func configureCamera() {
Expand Down