Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site picker button #23491

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Update site picker button #23491

merged 1 commit into from
Aug 15, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Aug 12, 2024

A couple of small changes to the site picker button:

  • Increase the size 36×32 to the recommended 44×44 to make sure it's easy to tap
  • Visually align with the disclosure indicators in the list
  • Use the native "title menu view" style
Screenshot 2024-08-12 at 7 18 59 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from jkmassel August 12, 2024 23:27
@kean kean added this to the Pending milestone Aug 12, 2024
@kean kean force-pushed the task/improve-site-picker-button branch from 07d92ef to 8b21e83 Compare August 12, 2024 23:28
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23491-8b21e83
Version25.2
Bundle IDorg.wordpress.alpha
Commit8b21e83
App Center BuildWPiOS - One-Offs #10469
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23491-8b21e83
Version25.2
Bundle IDcom.jetpack.alpha
Commit8b21e83
App Center Buildjetpack-installable-builds #9509
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – tested with various test sizes and in dark and light mode – both look good

@kean kean added this pull request to the merge queue Aug 15, 2024
Merged via the queue into trunk with commit d2fd31d Aug 15, 2024
24 checks passed
@kean kean deleted the task/improve-site-picker-button branch August 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants