From 79b1b9fa58a96cec5a528589402fe6fe7011f29a Mon Sep 17 00:00:00 2001 From: Tony Li Date: Mon, 22 Sep 2025 15:52:24 +1200 Subject: [PATCH 1/3] Remove the deployment target build settings on the Miniature targets --- WordPress/WordPress.xcodeproj/project.pbxproj | 6 ------ 1 file changed, 6 deletions(-) diff --git a/WordPress/WordPress.xcodeproj/project.pbxproj b/WordPress/WordPress.xcodeproj/project.pbxproj index 65b9331093b9..6cbcdea94876 100644 --- a/WordPress/WordPress.xcodeproj/project.pbxproj +++ b/WordPress/WordPress.xcodeproj/project.pbxproj @@ -4460,7 +4460,6 @@ INFOPLIST_KEY_UILaunchScreen_Generation = YES; INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; - IPHONEOS_DEPLOYMENT_TARGET = 16; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", @@ -4512,7 +4511,6 @@ INFOPLIST_KEY_UILaunchScreen_Generation = YES; INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; - IPHONEOS_DEPLOYMENT_TARGET = 16; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", @@ -4563,7 +4561,6 @@ INFOPLIST_KEY_UILaunchScreen_Generation = YES; INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight"; - IPHONEOS_DEPLOYMENT_TARGET = 16; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", @@ -4608,7 +4605,6 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GENERATE_INFOPLIST_FILE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 16; LOCALIZATION_PREFERS_STRING_CATALOGS = YES; MARKETING_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; @@ -4647,7 +4643,6 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GENERATE_INFOPLIST_FILE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 16; LOCALIZATION_PREFERS_STRING_CATALOGS = YES; MARKETING_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = NO; @@ -4685,7 +4680,6 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GENERATE_INFOPLIST_FILE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 16; LOCALIZATION_PREFERS_STRING_CATALOGS = YES; MARKETING_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = NO; From d213e3f518fd176cfc2bb91d4ec578e1faf0d5a4 Mon Sep 17 00:00:00 2001 From: Tony Li Date: Mon, 22 Sep 2025 15:52:48 +1200 Subject: [PATCH 2/3] Change deployment target to iOS 17 --- config/Common.xcconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/Common.xcconfig b/config/Common.xcconfig index 1fb649c342b0..b5164da16dc3 100644 --- a/config/Common.xcconfig +++ b/config/Common.xcconfig @@ -1,6 +1,6 @@ GCC_WARN_UNUSED_PARAMETER = YES WARNING_CFLAGS = -Wno-nullability-completeness -IPHONEOS_DEPLOYMENT_TARGET = 16.0 +IPHONEOS_DEPLOYMENT_TARGET = 17.0 CODE_SIGN_STYLE = Manual // See https://forums.swift.org/t/swift-cant-see-objc-methods-that-include-package-symbols/65732/9 From af7a7e49bf5c3c713af6d2b5f020552f21e38b7c Mon Sep 17 00:00:00 2001 From: Tony Li Date: Mon, 22 Sep 2025 16:26:16 +1200 Subject: [PATCH 3/3] Temporarily disable the 'Treat warnings as errors' build setting --- config/Common.xcconfig | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/config/Common.xcconfig b/config/Common.xcconfig index b5164da16dc3..7bc6bd1c6fe6 100644 --- a/config/Common.xcconfig +++ b/config/Common.xcconfig @@ -3,6 +3,11 @@ WARNING_CFLAGS = -Wno-nullability-completeness IPHONEOS_DEPLOYMENT_TARGET = 17.0 CODE_SIGN_STYLE = Manual +// Temporarily disable this build settings. There are too many new warnings (mostly using deprecated APIs) +// in the Objective-C code. We'll address them one by one, instead of on one go. +// We can remove this config once all warnings are addressed. +GCC_TREAT_WARNINGS_AS_ERRORS = NO + // See https://forums.swift.org/t/swift-cant-see-objc-methods-that-include-package-symbols/65732/9 // Without this flag, Objective-C APIs that contains Swift types in WordPressKit will not be available // to Swift code in the app target.