Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font style and line height on reader #7551

Merged
merged 1 commit into from Jul 13, 2017

Conversation

@elibud
Copy link
Contributor

@elibud elibud commented Jul 13, 2017

Fixes #7534

To test:
Go to reader and visit one article, check that the font is bigger.
Then you can change the accessibility values and check that that view adjust accordingly (go back and in again into the article).

SETTINGS
accessibility
BEFORE:
before
AFTER:
reader-1 6

Needs review: @aerych

@elibud elibud requested a review from aerych Jul 13, 2017
@elibud elibud self-assigned this Jul 13, 2017
@mattmiklic
Copy link
Member

@mattmiklic mattmiklic commented Jul 13, 2017

Everything looks good to me, at both regular and huge sizes. Was totally able to read an article through squinted eyes at the largest accessibility size. 🎉

@elibud elibud added this to the 8.1 milestone Jul 13, 2017
@aerych
aerych approved these changes Jul 13, 2017
Copy link
Member

@aerych aerych left a comment

Awesome :shipit: :)

@elibud elibud merged commit fc53868 into develop Jul 13, 2017
2 checks passed
2 checks passed
Buddybuild : WordPress/57a120bbe0f5520100e11c19 Build succeeded
Details
hound No violations found. Woof!
@elibud elibud deleted the issue/7534-update-font-size-on-reader branch Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.