Fix issue with crashes on startup on iPhone X. #8364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elibud
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, no idea why this is apparently only happening on the X.
The bug is pretty obvious in retrospective — the code was iterating over a list of potential places where the
.momdfile might be, but it never checked if it already found one.This in turn meant, that the order of items in the array returned from
pathsForResourcesOfType:_inDirectorymattered. For some reason, on iPhone X theExtensions.momdwas afterWordPress.momd, so the actual, correct result got overriden withnil, which lead to 💥.Why the order was apparently different on the X then any other device still remains a mystery.